-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New syntax #225
base: master
Are you sure you want to change the base?
New syntax #225
Conversation
rustamwin
commented
Nov 9, 2023
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ✔️ |
Fixed issues | #193, #171 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
============================================
+ Coverage 95.54% 96.35% +0.80%
- Complexity 174 234 +60
============================================
Files 14 16 +2
Lines 561 685 +124
============================================
+ Hits 536 660 +124
Misses 25 25
☔ View full report in Codecov by Sentry. |
PR SummaryThis pull request introduces numerous updates aimed at better organizing and streamlining how routes are handled in the system:
These changes all contribute to a more robust and efficient route handling system within the software, aligning the codebase with modern best practices in PHP coding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Update code of conduct #191 suggest use named arguments, and this must improve performance. In this PR keep routes/groups object and additional add new routes/groups objects with named arguments. Seems, this decrease performance...
-
This not fix Add friendly exception with examples for exception "middleware() can not be used after action()" #171.
We can mention it in docs or drop the current syntax.
Yes, doesn't fix directly. Since there is no exception, there is no need for it. |
But what goal of syntax change? |